CXXCBC-374: create_bucket does not return a BucketExists error when a duplicate bucket is created (#449)

* Add check for status code 400 and bucket exists message

* add test

* Add history feature not avaialble to bucket create and update

* linting

* undo history retention change

Author: Matt-Woz

core/operations/management/bucket_create.cxx

@@ -161,6 +161,9 @@ bucket_create_request::make_response(error_context::http&& ctx, const encoded_re
                 if (errors != nullptr) {
                     std::vector<std::string> error_list{};
                     for (const auto& [code, message] : errors->get_object()) {
+                        if (message.get_string().find("Bucket with given name already exists") != std::string::npos) {
+                            response.ctx.ec = errc::management::bucket_exists;
+                        }
                         error_list.emplace_back(message.get_string());
                     }
                     if (!error_list.empty()) {

test/test_integration_management.cxx

@@ -109,6 +109,14 @@ TEST_CASE("integration: bucket management", "[integration]")
                 REQUIRE(bucket_settings.compression_mode == resp.bucket.compression_mode);
                 REQUIRE(bucket_settings.replica_indexes == resp.bucket.replica_indexes);
             }
+
+            {
+                couchbase::core::operations::management::bucket_create_request req;
+                req.bucket = bucket_settings;
+                auto resp = test::utils::execute(integration.cluster, req);
+                REQUIRE(resp.ctx.ec == couchbase::errc::management::bucket_exists);
+            }
+
             std::uint64_t old_quota_mb{ 0 };
             {
                 couchbase::core::operations::management::bucket_get_all_request req{};