Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primary color to variables_hook.scss #1354

Open
1 task done
nukdokplex opened this issue Nov 1, 2023 · 6 comments
Open
1 task done

Add primary color to variables_hook.scss #1354

nukdokplex opened this issue Nov 1, 2023 · 6 comments
Labels
enhancement New feature or request inactive No activity

Comments

@nukdokplex
Copy link

Checklist

Is your feature request related to a problem? Please describe

I can't easily change primary color of my website without overwriting files in colors folder.

Describe the solution you'd like

I think people would like it if they could just specify the primary color (links, buttons, etc) in variables_hook.scss and it would apply to light and dark themes. I think that using formulas one can calculate the shade of this color that will best suit a light or dark theme. I saw this in Bootstrap and other sass frameworks.

Describe alternatives you've considered

No response

Additional context

No response

@nukdokplex nukdokplex added the enhancement New feature or request label Nov 1, 2023
@cotes2020
Copy link
Owner

Sounds interesting. I don't have a succinct implementation at the moment, so if you have a solution, please share it.

I think that using formulas one can calculate the shade of this color that will best suit a light or dark theme.

What is the technique of calculating color by formula, looking for an explanation.

@nukdokplex
Copy link
Author

@cotes2020

What is the technique of calculating color by formula, looking for an explanation.

Here you can see examples how does it works.

Copy link

github-actions bot commented Dec 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the inactive No activity label Dec 6, 2023
@cotes2020 cotes2020 added pending Awaiting decision or settlement and removed inactive No activity labels Dec 6, 2023
@cotes2020 cotes2020 added planning Considered for implementation help wanted Help us with this topic and removed pending Awaiting decision or settlement labels Jan 3, 2024
@nukdokplex
Copy link
Author

I think that I can try add this feature to project in my free time.

@cotes2020 cotes2020 removed the help wanted Help us with this topic label Mar 10, 2024
@cotes2020 cotes2020 removed the planning Considered for implementation label May 6, 2024
Copy link

github-actions bot commented Jul 6, 2024

This conversation has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the inactive No activity label Jul 6, 2024
Copy link

github-actions bot commented Nov 8, 2024

This conversation has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@cotes2020 cotes2020 removed the stale label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request inactive No activity
Projects
None yet
Development

No branches or pull requests

2 participants