Remove unnecessary event attribute from INIT Handshake Msgs

[ruthishvitwit]

Description

closes: #3847

Commit Message / Changelog Entry

Removed counterparty connection/channel id from both ConnOpenInit and ChanOpenInit as they will both be empty in this stage

chore(api)!: Remove unnecessary event attribute from INIT Handshake Msgs

see the guidelines for commit messages. (view raw markdown for examples)

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md).
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/) or specification (x/<module>/spec/).
• Added relevant godoc comments.
• Provide a commit message to be used for the changelog entry in the PR description for review.
• Re-reviewed Files changed in the Github PR explorer.
• Review Codecov Report in the comment section below once CI passes.

[crodriguezvega]

Thank you for this PR, @ruthishvitwit!

From a quick look at relayer and Hermes code, it looks like it should be safe to remove these from the events.

Relevant links for relayer: this and this. If the key is not present in the event, then the parser will just not try to parse the value and it will default to empty string anyway. Besides, the e2e tests are passing in your PR, so that's also a good sign.

Relevant links for hermes: this and this. Similar thing as with relayer: if the key is not present then the value will be a None, instead of an Some(""), but that should be fine too.

Mentioning here @jtieri and @ljoss17 for extra confirmation.

Maybe it would be nice also to mention this change in the v7-to-v8 migration docs.

[ljoss17]

Everything looks good on Hermes side, I ran the tests and haven't seen any issues with the changes from this PR

[crodriguezvega]

Thank you, @ruthishvitwit! Given that e2e tests use golang relayer and they pass, it should be fine with it.

[codecov-commenter]

Codecov Report

Merging #3867 (e55b264) into main (6fcedca) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3867      +/-   ##
==========================================
- Coverage   78.84%   78.84%   -0.01%     
==========================================
  Files         187      187              
  Lines       12950    12948       -2     
==========================================
- Hits        10211    10209       -2     
  Misses       2311     2311              
  Partials      428      428              

Impacted Files	Coverage Δ
.../apps/27-interchain-accounts/host/keeper/keeper.go	87.39% <ø> (ø)
modules/core/03-connection/keeper/events.go	100.00% <ø> (ø)
modules/core/04-channel/keeper/events.go	100.00% <ø> (ø)
modules/core/04-channel/keeper/handshake.go	89.50% <ø> (ø)
.../apps/27-interchain-accounts/host/client/cli/tx.go	29.70% <100.00%> (ø)
...s/apps/27-interchain-accounts/host/keeper/relay.go	71.08% <100.00%> (ø)
modules/apps/27-interchain-accounts/types/codec.go	79.54% <100.00%> (ø)

[DimitrisJim]

thanks @ruthishvitwit 🥳