remove Handler types #162
Merged
remove Handler types #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
May 7, 2021
| @@ -109,7 +109,7 @@ func (AppModule) RegisterInvariants(ir sdk.InvariantRegistry) { | |||
|
|
|||
| // Route implements the AppModule interface | |||
| func (am AppModule) Route() sdk.Route { | |||
| return sdk.NewRoute(types.RouterKey, NewHandler(am.keeper)) | |||
| return sdk.Route{} | |||
There was a problem hiding this comment.
SDK will know this is empty
AdityaSripal
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The handler type has been deprecated in the SDK. Since all our message types are registered on the Msg Server, these functions will never be called. In fact they had no code coverage
closes: #160
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes