Skip to content

Commit

Permalink
Remove unecessary modifications of version for non initializing chann…
Browse files Browse the repository at this point in the history
…el end.
  • Loading branch information
DimitrisJim committed Jun 28, 2023
1 parent 62a1232 commit 7849259
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions modules/core/04-channel/keeper/packet_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,8 @@ func (suite *KeeperTestSuite) TestAcknowledgePacket() {
channelCap = suite.chainA.GetChannelCapability(path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID)

// Move channel to correct state.
path.EndpointB.ChannelConfig.ProposedUpgrade.Fields.Version = ibcmock.UpgradeVersion

err = path.EndpointB.ChanUpgradeInit()
suite.Require().NoError(err)

Expand Down Expand Up @@ -744,7 +746,6 @@ func (suite *KeeperTestSuite) TestAcknowledgePacket() {

// Move channel to correct state.
path.EndpointA.ChannelConfig.ProposedUpgrade.Fields.Version = ibcmock.UpgradeVersion
path.EndpointB.ChannelConfig.ProposedUpgrade.Fields.Version = ibcmock.UpgradeVersion

err := path.EndpointA.ChanUpgradeInit()
suite.Require().NoError(err)
Expand Down Expand Up @@ -974,7 +975,6 @@ func (suite *KeeperTestSuite) TestAcknowledgeFlushStatus() {

// Move channel to UPGRADE_ACK, flush status set to flushing due to previous SendPacket
path.EndpointA.ChannelConfig.ProposedUpgrade.Fields.Version = ibcmock.UpgradeVersion
path.EndpointB.ChannelConfig.ProposedUpgrade.Fields.Version = ibcmock.UpgradeVersion

err = path.EndpointA.ChanUpgradeInit()
suite.Require().NoError(err)
Expand Down

0 comments on commit 7849259

Please sign in to comment.