Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly populate legacy Vote.Option field #9583

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Jun 25, 2021

Description

Manually tested.

Before:

./build/simd q gov votes 1
pagination:
  next_key: null
  total: "0"
votes:
- option: VOTE_OPTION_UNSPECIFIED
  options:
  - option: VOTE_OPTION_YES
    weight: "1.000000000000000000"
  proposal_id: "1"
  voter: cosmos137kdgzutlhnqk0t4et7g45ghl5vxupxvl09wct

After:

./build/simd q gov votes 1
pagination:
  next_key: null
  total: "0"
votes:
- option: VOTE_OPTION_YES
  options:
  - option: VOTE_OPTION_YES
    weight: "1.000000000000000000"
  proposal_id: "1"
  voter: cosmos137kdgzutlhnqk0t4et7g45ghl5vxupxvl09wct

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 marked this pull request as ready for review June 25, 2021 12:58
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #9583 (bb95afa) into master (7679820) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9583   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files         588      588           
  Lines       37277    37278    +1     
=======================================
+ Hits        22628    22629    +1     
  Misses      12699    12699           
  Partials     1950     1950           
Impacted Files Coverage Δ
x/gov/keeper/grpc_query.go 75.00% <100.00%> (+0.18%) ⬆️

Copy link
Contributor

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amaury1093 amaury1093 merged commit 7c0e693 into master Jun 25, 2021
@amaury1093 amaury1093 deleted the am/gov-q-votes branch June 25, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants