docs: fix broken interfaces links #9448

ryanchristo · 2021-06-02T19:19:51Z

Description

This pull request fixes broken /interfaces links and updates "Interfaces" on the main page to "Running a Node".

closes: #9441

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards. -n/a
Wrote unit and integration tests -n/a
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments. -n/a
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md -n/a
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

ryanchristo · 2021-06-02T20:15:18Z

docs/README.md

+  - title: Running a Node
+    desc: Running and interacting with nodes using the CLI and API.
    icon: interfaces
-    url: /interfaces/interfaces-intro.html
+    url: /run-node


Does this change make sense? This is the broken link referenced in #9441.

it makes sense to me

ryanchristo · 2021-06-02T20:20:02Z

The issue referenced the v0.42 documentation but the changes will need to be made for master as well. This pull request will be merged into release/v0.42.x at the moment. Let me know if that makes sense or if I should be making the changes to master and then using mergify to backport the changes to release/v0.42.x.

ryanchristo · 2021-06-03T17:04:31Z

Let me know if that makes sense or if I should be making the changes to master and then using mergify to backport the changes to release/v0.42.x.

I've updated the base branch to master and added the backport flag. I think that makes more sense.

codecov · 2021-06-03T17:11:38Z

Codecov Report

Merging #9448 (d08ea88) into master (a7b0eb1) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head d08ea88 differs from pull request most recent head f15810c. Consider uploading reports for the commit f15810c to get more accurate results

@@            Coverage Diff             @@
##           master    #9448      +/-   ##
==========================================
- Coverage   60.54%   60.43%   -0.12%     
==========================================
  Files         590      590              
  Lines       37287    37243      -44     
==========================================
- Hits        22577    22508      -69     
+ Misses      12763    12754       -9     
- Partials     1947     1981      +34

Impacted Files	Coverage Δ
x/distribution/simulation/operations.go	`82.24% <0.00%> (-9.48%)`	⬇️
x/staking/simulation/operations.go	`73.46% <0.00%> (-6.47%)`	⬇️
x/feegrant/simulation/operations.go	`78.84% <0.00%> (-6.11%)`	⬇️
x/gov/simulation/operations.go	`80.88% <0.00%> (-4.57%)`	⬇️
x/authz/client/testutil/tx.go	`97.63% <0.00%> (-0.16%)`	⬇️
x/feegrant/client/testutil/suite.go	`99.66% <0.00%> (-0.02%)`	⬇️
x/simulation/util.go	`0.00% <0.00%> (ø)`
x/feegrant/periodic_fee.go	`68.42% <0.00%> (ø)`
x/authz/simulation/operations.go	`77.64% <0.00%> (+0.13%)`	⬆️
x/authz/msgs.go	`56.96% <0.00%> (+5.82%)`	⬆️
... and 1 more

amaury1093 · 2021-06-08T11:57:18Z

docs/cn/basics/tx-lifecycle.md

@@ -39,7 +39,7 @@ appcli tx send <recipientAddress> 1000uatom --from <senderAddress> --gas auto --

 #### 其他的 Transaction 创建方法

-命令行是与应用程序进行交互的一种简便方法，但是 `Tx` 也可以使用 [REST interface](https://docs.cosmos.network/master/interfaces/rest.html) 或应用程序开发人员定义的某些其他入口点来创建命令行。从用户的角度来看，交互方式取决于他们正在使用的是页面还是钱包（例如， `Tx` 使用 [Lunie.io](https://lunie.io/#/) 创建并使用 Ledger Nano S 对其进行签名）。
+命令行是与应用程序进行交互的一种简便方法，但是 `Tx` 也可以使用 [REST interface](https://docs.cosmos.network/master/core/grpc_rest.html) 或应用程序开发人员定义的某些其他入口点来创建命令行。从用户的角度来看，交互方式取决于他们正在使用的是页面还是钱包（例如， `Tx` 使用 [Lunie.io](https://lunie.io/#/) 创建并使用 Ledger Nano S 对其进行签名）。


thanks for updating those too. just a note: they are way out of date (i think they're v0.39-compatible, maybe even older). Maybe we should create an issue to remove them?

opened #9479

amaury1093

thanks1

Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> (cherry picked from commit 37fc37d) # Conflicts: # docs/building-modules/messages-and-queries.md # docs/building-modules/module-interfaces.md # docs/building-modules/module-manager.md # docs/building-modules/query-services.md

* fix interfaces links (#9448) Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> (cherry picked from commit 37fc37d) # Conflicts: # docs/building-modules/messages-and-queries.md # docs/building-modules/module-interfaces.md # docs/building-modules/module-manager.md # docs/building-modules/query-services.md * resolve merge conflicts * revert rename codec Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com>

* CLI: `query ibc-transfer escrow-address` (cosmos#9383) * Fix the liveliness test Docker error (cosmos#9396) (cosmos#9402) (cherry picked from commit 44a4138) Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * docs: fix broken interfaces links (backport cosmos#9448) (cosmos#9478) * fix interfaces links (cosmos#9448) Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> (cherry picked from commit 37fc37d) # Conflicts: # docs/building-modules/messages-and-queries.md # docs/building-modules/module-interfaces.md # docs/building-modules/module-manager.md # docs/building-modules/query-services.md * resolve merge conflicts * revert rename codec Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com> * backport: fix ibc genesis export bug (cosmos#9401) * correctly set next identifier sequence in genesis export for clients/connections/channels * add changelog * fix linting (cosmos#9531) * fix: testnet cli command update genesis supply (backport cosmos#9497) (cosmos#9513) * fix: testnet cli command update genesis supply (cosmos#9497)  ## Description closes: cosmos#9372  ### This PR makes the `testnet` command update the bank genesis supply. When using the `testnet` cli command, it creates nodes and balances, but does **not** update the supply. When using this in conjunction with `add-genesis-account` which **does** update the supply, it creates an invalid genesis file. This PR updates the testnet command to properly set the supply. * feat: add header hash to `Context` (backport cosmos#9390) (cosmos#9395) * feat: add header hash to `Context` (cosmos#9390) * baseapp, types: add header hash to * changelog (cherry picked from commit 151d6c5) # Conflicts: # CHANGELOG.md * Fix conflicts Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> * fix: x/gov deposits querier (Initial Deposit) (backport cosmos#9288) (cosmos#9453) * fix: x/gov deposits querier (Initial Deposit) (cosmos#9288) * copied from old PR * fix errors * add test * Update x/gov/client/utils/query.go Co-authored-by: Robert Zaremba <robert@zaremba.ch> * fix tests * fix failing test * add test * update test * fix tests * fix deposit query * fix test * update tests * add more tests * address lint error * address lint error * review changes Co-authored-by: Robert Zaremba <robert@zaremba.ch> (cherry picked from commit 66ee994) # Conflicts: # CHANGELOG.md # x/gov/client/cli/query.go # x/gov/client/testutil/cli_test.go # x/gov/client/utils/query.go * resolve conflicts Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com> Co-authored-by: aleem1314 <aleem@vitwit.com> * feat: add `RefundGas` function to `GasMeter` (backport cosmos#9403) (cosmos#9444) * feat: add `RefundGas` function to `GasMeter` (cosmos#9403) * feat: add RefundGas function to GasMeter * changelog * add comment about use case * Apply suggestions from code review Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> (cherry picked from commit 90edeb6) # Conflicts: # CHANGELOG.md * conflicts * fix * Update CHANGELOG.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze <federico.kunze94@gmail.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * fix: Bank module init genesis optimization (backport cosmos#9428) (cosmos#9440) * fix: Bank module init genesis optimization (cosmos#9428) * optimize the bank module genesis initialization * remove k.setBalances & k.clearBalances and update changelog * fix lint Co-authored-by: Aaron Craelius <aaron@regen.network> (cherry picked from commit 2ae7875) # Conflicts: # CHANGELOG.md # x/bank/keeper/genesis.go # x/bank/keeper/send.go * fix conflicts * Update CHANGELOG.md Co-authored-by: yys <sw.yunsuk@gmail.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> * fix: update simapp to use correct default broadcast mode (backport cosmos#9408) (cosmos#9527) * fix: update simapp to use correct default broadcast mode (cosmos#9408) (cherry picked from commit 80330ec) * Add changelog Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> * Backport: IBC query header/node-state fixes (cosmos#9385) * fix ibc query header/node-state cmds * changelog Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> * build(deps): tendermint version (backport cosmos#9541) (cosmos#9542) * build(deps): tendermint version (cosmos#9541) * bump tendermint version * go mod tidy (cherry picked from commit e4673ad) * add changelog entry * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * feat: add cosmos-sdk Version (backport cosmos#9429) (cosmos#9543) * feat: add cosmos-sdk Version (cosmos#9429)  ## Description Add CosmosSDKVersion to nodeInfo. closes: cosmos#9420 (cherry picked from commit 105ad99) # Conflicts: # CHANGELOG.md # CONTRIBUTING.md # docs/core/proto-docs.md * resolve conflicts * resolve conflicts Co-authored-by: Marko <marbar3778@yahoo.com> * fix: set header hash every block (backport cosmos#9552) (cosmos#9555) * fix: set header hash every block (cosmos#9552) ## Description - Sets the header hash on every block (ref cosmos#9390). Previously was only set during initialization for `deliverState`. - Closes cosmos#9514  * chore: Update release notes and Changelog for 0.42.6 (cosmos#9544) * Update release notes * Clean up changelog Co-authored-by: Ethan Buchman <ethan@coinculture.info> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com> Co-authored-by: aleem1314 <aleem@vitwit.com> Co-authored-by: Federico Kunze <federico.kunze94@gmail.com> Co-authored-by: yys <sw.yunsuk@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

ryanchristo commented Jun 2, 2021

View reviewed changes

ryanchristo marked this pull request as ready for review June 2, 2021 20:20

ryanchristo requested review from aaronc, alessio and alexanderbez as code owners June 2, 2021 20:20

fix interfaces links

d08ea88

ryanchristo force-pushed the ryan/9441-fix-interfaces-links branch from 09cfa12 to d08ea88 Compare June 3, 2021 16:57

ryanchristo changed the base branch from release/v0.42.x to master June 3, 2021 16:57

ryanchristo added the backport/0.42.x (Stargate) label Jun 3, 2021

tac0turtle approved these changes Jun 3, 2021

View reviewed changes

Merge branch 'master' into ryan/9441-fix-interfaces-links

5955edc

github-actions bot added the T:Docs Changes and features related to documentation. label Jun 4, 2021

amaury1093 self-assigned this Jun 7, 2021

amaury1093 reviewed Jun 8, 2021

View reviewed changes

amaury1093 approved these changes Jun 8, 2021

View reviewed changes

Merge branch 'master' into ryan/9441-fix-interfaces-links

f15810c

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 8, 2021

mergify bot merged commit 37fc37d into master Jun 8, 2021

mergify bot deleted the ryan/9441-fix-interfaces-links branch June 8, 2021 12:03

mergify bot mentioned this pull request Jun 8, 2021

docs: fix broken interfaces links (backport #9448) #9478

Merged

ryanchristo mentioned this pull request Jun 8, 2021

Clean up translated documentation #9479

Closed

4 tasks

naiba4 mentioned this pull request Oct 31, 2023

[Snyk] Fix for 1 vulnerabilities naiba4/cosmos-sdk#3

Open

stefan-thothmind mentioned this pull request Nov 1, 2023

[Snyk] Fix for 1 vulnerabilities stefan-thothmind/cosmos-sdk#11

Open

keylogic1 mentioned this pull request Nov 3, 2023

[Snyk] Fix for 1 vulnerabilities neutron-org/cosmos-sdk#7

Closed

stefan-thothmind mentioned this pull request Nov 16, 2023

[Snyk] Fix for 1 vulnerabilities stefan-thothmind/cosmos-sdk#13

Open

naiba4 mentioned this pull request Nov 17, 2023

[Snyk] Fix for 1 vulnerabilities naiba4/cosmos-sdk#4

Open

keylogic1 mentioned this pull request Nov 17, 2023

[Snyk] Fix for 1 vulnerabilities neutron-org/cosmos-sdk#8

Closed

naiba4 mentioned this pull request Dec 14, 2023

[Snyk] Fix for 1 vulnerabilities naiba4/cosmos-sdk#5

Open

stefan-thothmind mentioned this pull request Dec 14, 2023

[Snyk] Fix for 1 vulnerabilities stefan-thothmind/cosmos-sdk#15

Open

keylogic1 mentioned this pull request Dec 15, 2023

[Snyk] Fix for 1 vulnerabilities neutron-org/cosmos-sdk#12

Closed

stefan-thothmind mentioned this pull request Jan 5, 2024

[Snyk] Fix for 1 vulnerabilities stefan-thothmind/cosmos-sdk#16

Open

naiba4 mentioned this pull request Jan 5, 2024

[Snyk] Fix for 1 vulnerabilities naiba4/cosmos-sdk#6

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: fix broken interfaces links #9448

docs: fix broken interfaces links #9448

ryanchristo commented Jun 2, 2021 •

edited

Loading

ryanchristo Jun 2, 2021

amaury1093 Jun 8, 2021

ryanchristo commented Jun 2, 2021

ryanchristo commented Jun 3, 2021

codecov bot commented Jun 3, 2021 •

edited

Loading

amaury1093 Jun 8, 2021

ryanchristo Jun 8, 2021

amaury1093 left a comment

docs: fix broken interfaces links #9448

docs: fix broken interfaces links #9448

Conversation

ryanchristo commented Jun 2, 2021 • edited Loading

Description

ryanchristo Jun 2, 2021

Choose a reason for hiding this comment

amaury1093 Jun 8, 2021

Choose a reason for hiding this comment

ryanchristo commented Jun 2, 2021

ryanchristo commented Jun 3, 2021

codecov bot commented Jun 3, 2021 • edited Loading

Codecov Report

amaury1093 Jun 8, 2021

Choose a reason for hiding this comment

ryanchristo Jun 8, 2021

Choose a reason for hiding this comment

amaury1093 left a comment

Choose a reason for hiding this comment

ryanchristo commented Jun 2, 2021 •

edited

Loading

codecov bot commented Jun 3, 2021 •

edited

Loading