-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename clientCtx.JSONMarshaler to JSONCodec #9251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Keys
Keybase, KMS and HSMs
C:x/auth
C:x/authz
C:x/bank
C:x/crisis
C:x/distribution
distribution module related
C:x/evidence
C:x/feegrant
C:x/genutil
genutil module issues
C:x/gov
C:x/mint
C:x/params
C:x/slashing
C:x/staking
labels
May 3, 2021
9 tasks
github-actions
bot
added
T: ADR
An issue or PR relating to an architectural decision record
T:Docs
Changes and features related to documentation.
labels
May 3, 2021
colin-axner
approved these changes
May 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Codecov Report
@@ Coverage Diff @@
## master #9251 +/- ##
=======================================
Coverage 60.14% 60.14%
=======================================
Files 595 595
Lines 37194 37194
=======================================
Hits 22369 22369
Misses 12846 12846
Partials 1979 1979
|
aaronc
approved these changes
May 3, 2021
amaury1093
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
May 3, 2021
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Rename clientCtx.JSONMarshaler to JSONCodec * change md files * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
C:CLI
C:Keys
Keybase, KMS and HSMs
C:x/auth
C:x/authz
C:x/bank
C:x/crisis
C:x/distribution
distribution module related
C:x/evidence
C:x/feegrant
C:x/genutil
genutil module issues
C:x/gov
C:x/mint
C:x/params
C:x/slashing
C:x/staking
T: ADR
An issue or PR relating to an architectural decision record
T:Docs
Changes and features related to documentation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
follow-up: #9226
ref: #9218
ref: #9226 (comment)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes