auth: consistency in antehandler #9144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #9144 +/- ##
=======================================
Coverage 58.80% 58.80%
=======================================
Files 583 583
Lines 32748 32749 +1
=======================================
+ Hits 19257 19258 +1
Misses 11214 11214
Partials 2277 2277
|
amaury1093
approved these changes
Apr 20, 2021
alessio
reviewed
Apr 20, 2021
| @@ -179,6 +179,12 @@ type ( | |||
| } | |||
| ) | |||
|
|
|||
| // TxTimeoutHeightDecorator defines an AnteHandler decorator that checks for a | |||
| // tx height timeout. | |||
| func NewTxTimeoutHeightDecorator() TxTimeoutHeightDecorator { | |||
There was a problem hiding this comment.
IMHO this might be worth of a changelog addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add NewTxTimeoutHeightDecorator() to be consistent with other antehandler functions.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes