Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert unintended skip test in feegrant #8789

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Revert unintended skip test in feegrant #8789

merged 2 commits into from
Mar 4, 2021

Conversation

sahith-narahari
Copy link
Contributor

Description

This seems to be an unintended change from #8780. Reverting it

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@sahith-narahari sahith-narahari added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #8789 (5021cd7) into master (da064e1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8789      +/-   ##
==========================================
+ Coverage   59.34%   59.37%   +0.02%     
==========================================
  Files         563      563              
  Lines       31251    31251              
==========================================
+ Hits        18545    18554       +9     
+ Misses      10551    10543       -8     
+ Partials     2155     2154       -1     
Impacted Files Coverage Δ
x/crisis/keeper/keeper.go 86.20% <100.00%> (ø)
x/feegrant/simulation/decoder.go 100.00% <0.00%> (+100.00%) ⬆️

@mergify mergify bot merged commit 72fb8b3 into master Mar 4, 2021
@mergify mergify bot deleted the sahith/revert-skip branch March 4, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants