Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed broken links, typos #8783

Merged
merged 7 commits into from
Mar 9, 2021
Merged

fixed broken links, typos #8783

merged 7 commits into from
Mar 9, 2021

Conversation

charleenfei
Copy link
Contributor

Description

This PR fixes the broken links and typos that I found in a review of the SDK docs, and contains no code.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • [x ] Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @charleenfei for going through the docs, they look good to me

docs/ibc/overview.md Outdated Show resolved Hide resolved
@amaury1093 amaury1093 added backport/0.41.x (Stargate) T:Docs Changes and features related to documentation. labels Mar 4, 2021
charleenfei and others added 2 commits March 4, 2021 14:02
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #8783 (ce62cfb) into master (c2d5b24) will not change coverage.
The diff coverage is 64.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8783   +/-   ##
=======================================
  Coverage   59.45%   59.45%           
=======================================
  Files         563      563           
  Lines       31277    31277           
=======================================
  Hits        18597    18597           
  Misses      10518    10518           
  Partials     2162     2162           
Impacted Files Coverage Δ
x/bank/keeper/migrations.go 50.00% <0.00%> (ø)
x/bank/legacy/v043/store.go 82.60% <ø> (ø)
x/capability/simulation/decoder.go 100.00% <ø> (ø)
x/distribution/keeper/migrations.go 50.00% <0.00%> (ø)
x/distribution/legacy/v043/helpers.go 100.00% <ø> (ø)
x/distribution/legacy/v043/store.go 100.00% <ø> (ø)
x/gov/keeper/migrations.go 50.00% <0.00%> (ø)
x/gov/legacy/v043/store.go 84.61% <ø> (ø)
x/slashing/keeper/migrations.go 50.00% <0.00%> (ø)
x/staking/keeper/migrations.go 50.00% <0.00%> (ø)
... and 2 more

@amaury1093
Copy link
Contributor

@charleenfei could you address #8783 (comment), and then we'll get this merged?

amaury1093 and others added 2 commits March 9, 2021 10:41
Co-authored-by: Marko <markobaricevic3778@gmail.com>
Co-authored-by: Marko <markobaricevic3778@gmail.com>
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 9, 2021
@mergify mergify bot merged commit 24ed401 into cosmos:master Mar 9, 2021
mergify bot pushed a commit that referenced this pull request Mar 9, 2021
* fixed broken links, typos

* Update docs/ibc/overview.md

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

* Update docs/intro/sdk-app-architecture.md

Co-authored-by: Marko <markobaricevic3778@gmail.com>

* Update docs/building-modules/simulator.md

Co-authored-by: Marko <markobaricevic3778@gmail.com>

Co-authored-by: chrly <chrly@chrlys-MacBook-Pro.local>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Marko <markobaricevic3778@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 24ed401)
alessio pushed a commit that referenced this pull request Mar 9, 2021
* fixed broken links, typos

* Update docs/ibc/overview.md

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

* Update docs/intro/sdk-app-architecture.md

Co-authored-by: Marko <markobaricevic3778@gmail.com>

* Update docs/building-modules/simulator.md

Co-authored-by: Marko <markobaricevic3778@gmail.com>

Co-authored-by: chrly <chrly@chrlys-MacBook-Pro.local>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Marko <markobaricevic3778@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 24ed401)

Co-authored-by: Charly <16255463+charleenfei@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants