-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed broken links, typos #8783
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleenfei
requested review from
aaronc,
alessio and
alexanderbez
as code owners
March 4, 2021 11:36
tac0turtle
reviewed
Mar 4, 2021
amaury1093
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @charleenfei for going through the docs, they look good to me
amaury1093
added
backport/0.41.x (Stargate)
T:Docs
Changes and features related to documentation.
labels
Mar 4, 2021
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
jgimeno
approved these changes
Mar 5, 2021
Codecov Report
@@ Coverage Diff @@
## master #8783 +/- ##
=======================================
Coverage 59.45% 59.45%
=======================================
Files 563 563
Lines 31277 31277
=======================================
Hits 18597 18597
Misses 10518 10518
Partials 2162 2162
|
amaury1093
added
backport/0.42.x (Stargate)
and removed
backport/0.41.x (Stargate)
labels
Mar 5, 2021
@charleenfei could you address #8783 (comment), and then we'll get this merged? |
tac0turtle
reviewed
Mar 9, 2021
Co-authored-by: Marko <markobaricevic3778@gmail.com>
Co-authored-by: Marko <markobaricevic3778@gmail.com>
amaury1093
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Mar 9, 2021
mergify bot
pushed a commit
that referenced
this pull request
Mar 9, 2021
* fixed broken links, typos * Update docs/ibc/overview.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * Update docs/intro/sdk-app-architecture.md Co-authored-by: Marko <markobaricevic3778@gmail.com> * Update docs/building-modules/simulator.md Co-authored-by: Marko <markobaricevic3778@gmail.com> Co-authored-by: chrly <chrly@chrlys-MacBook-Pro.local> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> Co-authored-by: Marko <markobaricevic3778@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 24ed401)
alessio
pushed a commit
that referenced
this pull request
Mar 9, 2021
* fixed broken links, typos * Update docs/ibc/overview.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * Update docs/intro/sdk-app-architecture.md Co-authored-by: Marko <markobaricevic3778@gmail.com> * Update docs/building-modules/simulator.md Co-authored-by: Marko <markobaricevic3778@gmail.com> Co-authored-by: chrly <chrly@chrlys-MacBook-Pro.local> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> Co-authored-by: Marko <markobaricevic3778@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 24ed401) Co-authored-by: Charly <16255463+charleenfei@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
T:Docs
Changes and features related to documentation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the broken links and typos that I found in a review of the SDK docs, and contains no code.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes