Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: create package for unsafe bytes convertion #8733

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

robert-zaremba
Copy link
Collaborator

Description

We start to duplicate a code for unsafe and with 0 allocation bytes <-> string convertion. This PR moves the code to a single place - an internal conv package.

Ref: #8719 (comment)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #8733 (5ae6bae) into master (b1c72fd) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8733      +/-   ##
==========================================
- Coverage   61.40%   61.39%   -0.01%     
==========================================
  Files         671      672       +1     
  Lines       38348    38346       -2     
==========================================
- Hits        23546    23544       -2     
+ Misses      12335    12334       -1     
- Partials     2467     2468       +1     
Impacted Files Coverage Δ
x/auth/legacy/legacytx/stdsign.go 82.97% <ø> (ø)
store/cachekv/store.go 88.17% <50.00%> (+1.04%) ⬆️
x/auth/legacy/legacytx/stdtx.go 80.85% <50.00%> (-1.38%) ⬇️
internal/conv/string.go 100.00% <100.00%> (ø)
types/address/hash.go 100.00% <100.00%> (ø)

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK'd

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 1, 2021
@mergify mergify bot merged commit 5f2b90c into master Mar 1, 2021
@mergify mergify bot deleted the robert/unsafe-conv branch March 1, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants