Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix testutil/network build #8617

Merged

Conversation

boz
Copy link
Contributor

@boz boz commented Feb 18, 2021

  • Tendermint's DefaultLogLevel is now a string.

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

* Tendermint's `DefaultLogLevel` is now a string.
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #8617 (434ba78) into release/v0.41.x (2a5818c) will decrease coverage by 0.00%.
The diff coverage is 41.09%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.41.x    #8617      +/-   ##
===================================================
- Coverage            61.93%   61.92%   -0.01%     
===================================================
  Files                  611      611              
  Lines                35250    35246       -4     
===================================================
- Hits                 21831    21827       -4     
  Misses               11136    11136              
  Partials              2283     2283              
Impacted Files Coverage Δ
baseapp/grpcserver.go 2.70% <0.00%> (+0.13%) ⬆️
store/rootmulti/store.go 66.05% <0.00%> (ø)
testutil/network/network.go 90.54% <0.00%> (ø)
x/staking/keeper/keeper.go 56.66% <ø> (-1.40%) ⬇️
x/staking/keeper/validator.go 80.52% <ø> (+0.03%) ⬆️
client/grpc_query.go 29.16% <40.00%> (+0.90%) ⬆️
baseapp/grpcrouter.go 80.00% <50.00%> (-6.05%) ⬇️
codec/types/any.go 64.00% <100.00%> (+3.13%) ⬆️
crypto/hd/hdpath.go 98.49% <100.00%> (+0.03%) ⬆️
server/grpc/server.go 62.50% <100.00%> (ø)
... and 4 more

@anilcse anilcse requested a review from amaury1093 February 18, 2021 07:22
@alessio alessio merged commit 6ef4bed into cosmos:release/v0.41.x Feb 18, 2021
@alessio
Copy link
Contributor

alessio commented Feb 18, 2021

@Mergifyio backport release/v0.41.x

mergify bot pushed a commit that referenced this pull request Feb 18, 2021
Tendermint's `DefaultLogLevel` is now a string.

(cherry picked from commit 6ef4bed)
@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2021

Command backport release/v0.41.x: success

Backports have been created

alessio pushed a commit that referenced this pull request Feb 18, 2021
Tendermint's `DefaultLogLevel` is now a string.
@alessio alessio added this to the v0.41.3 milestone Feb 18, 2021
@boz boz deleted the boz/testutil-network-build branch February 19, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants