Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize create proposal #8586

Merged

Conversation

PrathyushaLakkireddy
Copy link
Contributor

Description

closes: #8571


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #8586 (bddc63f) into master (a534a96) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8586   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files         656      656           
  Lines       37542    37542           
=======================================
  Hits        23074    23074           
  Misses      12059    12059           
  Partials     2409     2409           
Impacted Files Coverage Δ
x/gov/types/proposal.go 19.78% <0.00%> (ø)

@PrathyushaLakkireddy PrathyushaLakkireddy marked this pull request as ready for review February 15, 2021 11:18
@amaury1093 amaury1093 added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. A:automerge Automatically merge PR once all prerequisites pass. C:x/gov labels Feb 15, 2021
@mergify mergify bot merged commit d3e51cf into cosmos:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/gov Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/gov/types: NewProposal unnecessarily creates a Proposal object that’s discarded on any error
3 participants