-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enrich versioning with build deps #7848
Conversation
It's command's objective to actually display versioning information.
Codecov Report
@@ Coverage Diff @@
## master #7848 +/- ##
==========================================
- Coverage 54.23% 54.23% -0.01%
==========================================
Files 609 609
Lines 38807 38817 +10
==========================================
+ Hits 21046 21051 +5
- Misses 15604 15609 +5
Partials 2157 2157 |
A practical example follows. This is the information presently displayed by
The following is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Would like to understand the context of this addition: did a user ask for it? In what use-cases is it useful (one could just go to github to check the same thing)?
@amaurymartiny yep: #7835 Plus I bet users would find extremely useful while debugging to know what version of the cosmos-sdk their app builds on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK (so long as this is only visible with the --long
flag).
The version command now displays the list of
build dependencies.
Also fix version's command output stream.
version's output should go to stdout as it's the command's
objective to actually display versioning information.
closes: #7835
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes