Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: s/TENDERMINT/COSMOS/ #7486

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Makefile: s/TENDERMINT/COSMOS/ #7486

merged 2 commits into from
Oct 8, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Oct 8, 2020


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #7486 into master will decrease coverage by 5.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7486      +/-   ##
==========================================
- Coverage   58.02%   52.86%   -5.17%     
==========================================
  Files         306      437     +131     
  Lines       19484    27345    +7861     
==========================================
+ Hits        11306    14456    +3150     
- Misses       6970    11405    +4435     
- Partials     1208     1484     +276     

@alessio alessio merged commit 1832ab2 into master Oct 8, 2020
@alessio alessio deleted the alessio/fix-var-names branch October 8, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants