-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: Update AccountRetriever #7006
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7006 +/- ##
==========================================
- Coverage 61.95% 60.98% -0.98%
==========================================
Files 520 380 -140
Lines 32036 24778 -7258
==========================================
- Hits 19848 15110 -4738
+ Misses 10559 8476 -2083
+ Partials 1629 1192 -437 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . Just need to remove all references to NodeQuerier
. Could you also change AccountRetriever's signature in ADR020?
Putting a red cross for now to avoid automerge.
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
The
AccountRetriever
now has no dependencies and solely relies on theclient.Context
provided as an argument.closes: #6985
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes