Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Update AccountRetriever #7006

Merged
merged 13 commits into from
Aug 13, 2020
Merged

auth: Update AccountRetriever #7006

merged 13 commits into from
Aug 13, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 11, 2020

Description

The AccountRetriever now has no dependencies and solely relies on the client.Context provided as an argument.

closes: #6985


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #7006 into master will decrease coverage by 0.97%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##           master    #7006      +/-   ##
==========================================
- Coverage   61.95%   60.98%   -0.98%     
==========================================
  Files         520      380     -140     
  Lines       32036    24778    -7258     
==========================================
- Hits        19848    15110    -4738     
+ Misses      10559     8476    -2083     
+ Partials     1629     1192     -437     

@alexanderbez alexanderbez marked this pull request as ready for review August 12, 2020 16:10
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 12, 2020
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Just need to remove all references to NodeQuerier. Could you also change AccountRetriever's signature in ADR020?

Putting a red cross for now to avoid automerge.

client/account_retriever.go Outdated Show resolved Hide resolved
x/auth/types/account_retriever.go Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderbez alexanderbez merged commit 6a7cf44 into master Aug 13, 2020
@alexanderbez alexanderbez deleted the bez/6985-accnt-retr-fix branch August 13, 2020 14:22
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate AccountRetriever to proto
3 participants