docker: fix version cmd #6947
Merged
docker: fix version cmd #6947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
added
the
A:automerge
tac0turtle
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
tac0turtle
commented
Aug 5, 2020
| @@ -23,8 +23,7 @@ WORKDIR /go/src/github.com/cosmos/cosmos-sdk | |||
| COPY . . | |||
|
|
|||
| # build Cosmos SDK, remove packages | |||
| RUN make tools && \ | |||
There was a problem hiding this comment.
non of the tools are needed here last I checked. please correct me if wrong.
|
to test run output should be: |
ethanfrey
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Looks good. Thanks @marbar3778
This will definitely make it easier to debug issues with the docker images
amaury1093
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
simd version was not displaying a version because
actions/checkoutdid not bring with it the latest tag. I explicity set it to bring the latest tag in order to provide something forgit describeBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes