Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Grpc gateway annotations #6918

Merged
merged 101 commits into from
Aug 14, 2020
Merged

Add Grpc gateway annotations #6918

merged 101 commits into from
Aug 14, 2020

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Aug 3, 2020

ref: #5921

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

amaury1093
amaury1093 reviewed Aug 3, 2020
View reviewed changes
proto/cosmos/distribution/query.proto Outdated Show resolved Hide resolved
x/bank/module.go Outdated Show resolved Hide resolved
proto/cosmos/distribution/query.proto Outdated Show resolved Hide resolved
aaronc
aaronc reviewed Aug 3, 2020
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why v1 everywhere? Shouldn't we just match the package name?

@anilcse anilcse force-pushed the atheesh/5921-grpc-gateway branch from 059d8c7 to 7a10390 Compare August 10, 2020 12:31
anilcse
anilcse approved these changes Aug 10, 2020
View reviewed changes
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

amaury1093
amaury1093 reviewed Aug 12, 2020
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all annotations, they mostly lgtm 🎉.

proto/ibc/connection/query.proto Outdated Show resolved Hide resolved
proto/cosmos/evidence/v1beta1/query.proto Outdated Show resolved Hide resolved
proto/cosmos/evidence/v1beta1/query.proto Outdated Show resolved Hide resolved
scripts/protocgen.sh Outdated Show resolved Hide resolved
This was referenced Aug 13, 2020
Merged
Closed
amaury1093
amaury1093 approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 14, 2020
@mergify mergify bot merged commit f87624e into master Aug 14, 2020
@mergify mergify bot deleted the atheesh/5921-grpc-gateway branch August 14, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle left review comments

@anilcse anilcse anilcse approved these changes

@aaronc aaronc aaronc left review comments

@fedekunze fedekunze fedekunze approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@alessio alessio Awaiting requested review from alessio

@clevinson clevinson Awaiting requested review from clevinson

@jgimeno jgimeno Awaiting requested review from jgimeno

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@sahith-narahari sahith-narahari Awaiting requested review from sahith-narahari

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@atheeshp @amaury1093 @aaronc @anilcse @alexanderbez @sahith-narahari @tac0turtle @fedekunze