-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keys: CLI Remove Viper #6613
Merged
Merged
keys: CLI Remove Viper #6613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
C:CLI
C:Keys
Keybase, KMS and HSMs
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
A:automerge
Automatically merge PR once all prerequisites pass.
labels
Jul 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #6613 +/- ##
==========================================
+ Coverage 55.60% 57.53% +1.93%
==========================================
Files 457 493 +36
Lines 27440 29558 +2118
==========================================
+ Hits 15257 17006 +1749
- Misses 11083 11339 +256
- Partials 1100 1213 +113 |
alexanderbez
requested review from
aaronc,
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
July 6, 2020 17:36
…osmos-sdk into bez/6571-viper-removal-cli-keys
jgimeno
approved these changes
Jul 6, 2020
tac0turtle
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
C:CLI
C:Keys
Keybase, KMS and HSMs
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #6571
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes