Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor ibc ante_test #6610

Merged
merged 7 commits into from
Jul 7, 2020
Merged

refactor ibc ante_test #6610

merged 7 commits into from
Jul 7, 2020

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Jul 6, 2020

Description

ref: #5558

blocked on: #6611


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #6610 into master will increase coverage by 7.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6610      +/-   ##
==========================================
+ Coverage   50.36%   57.74%   +7.37%     
==========================================
  Files         243      495     +252     
  Lines       13137    29664   +16527     
==========================================
+ Hits         6617    17130   +10513     
- Misses       6010    11301    +5291     
- Partials      510     1233     +723     

@colin-axner colin-axner added the S:blocked Status: Blocked label Jul 6, 2020
@colin-axner colin-axner changed the title refactor ibc ante refactor ibc ante_test Jul 6, 2020
@colin-axner colin-axner marked this pull request as ready for review July 6, 2020 15:10
@colin-axner colin-axner added R4R and removed WIP labels Jul 6, 2020
@colin-axner
Copy link
Contributor Author

this is r4r, one test just fails on the issue this is blocked on. Pending that change it should be good to go

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending test fix

Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, pending unblocking issue

@AdityaSripal AdityaSripal mentioned this pull request Jul 6, 2020
9 tasks
@alexanderbez alexanderbez removed the R4R label Jul 7, 2020
@colin-axner colin-axner added A:automerge Automatically merge PR once all prerequisites pass. and removed S:blocked Status: Blocked labels Jul 7, 2020
@mergify mergify bot merged commit f163ec6 into master Jul 7, 2020
@mergify mergify bot deleted the colin/5558-refactor-ante branch July 7, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants