-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove viper global singleton from x/genutil #6596
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6596 +/- ##
==========================================
- Coverage 57.99% 57.66% -0.33%
==========================================
Files 370 493 +123
Lines 23551 29621 +6070
==========================================
+ Hits 13659 17082 +3423
- Misses 8941 11314 +2373
- Partials 951 1225 +274 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @jgimeno! I left a few comments and questions 👍
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
…mos/cosmos-sdk into jonathan/genutil-viper-global-remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 🎉
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes