Use Context in Command instead of Argument + Util #6572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6572 +/- ##
==========================================
+ Coverage 56.84% 57.04% +0.19%
==========================================
Files 481 481
Lines 28921 28939 +18
==========================================
+ Hits 16441 16507 +66
+ Misses 11314 11258 -56
- Partials 1166 1174 +8 |
alexanderbez
requested review from
aaronc,
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
alessio
reviewed
Jul 2, 2020
| @@ -11,6 +11,23 @@ import ( | |||
| "github.com/cosmos/cosmos-sdk/client/flags" | |||
| ) | |||
|
|
|||
| type contextKey string | |||
There was a problem hiding this comment.
Why defining a string type alias?
There was a problem hiding this comment.
You need an addressable and comparable type for context keys.
fedekunze
approved these changes
Jul 2, 2020
sahith-narahari
approved these changes
Jul 2, 2020
alessio
reviewed
Jul 2, 2020
jgimeno
reviewed
Jul 2, 2020
| testCases := []struct { | ||
| name string | ||
| from, to sdk.AccAddress |
There was a problem hiding this comment.
It is fun that we came to same conclussions:
cosmos-sdk/x/bank/client/cli/cli_test.go
Line 193 in 3c5dec4
Probably I will wait your merge to update mine, I needed to extract the SendTx in order to test the Auth module.
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
alexanderbez
added
the
A:automerge
|
Hope this makes things cleaner! 👍 |
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Use context * use PersistentPreRunE * undo * use init context * Update types * update tests * implement tests * Update simapp/cmd/simcli/main.go Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * Update simapp/cmd/simcli/main.go Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * Update x/bank/client/cli/tx.go Co-authored-by: Alessio Treglia <alessio@tendermint.com> * fix build Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a Command's Context instead of passing by argument. This allows us to leverage pre-execution hooks and reduces the need for viper.
ref: #6571
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes