-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move codec.RegisterCrypto and codec.Cdc to new packages #6330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6330 +/- ##
==========================================
- Coverage 55.66% 55.63% -0.04%
==========================================
Files 448 448
Lines 26956 26951 -5
==========================================
- Hits 15005 14994 -11
- Misses 10877 10883 +6
Partials 1074 1074 |
aaronc
changed the title
Move codec.Cdc to legacy_global package
Move codec.RegisterCrypto and codec.Cdc to new packages
Jun 2, 2020
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
June 2, 2020 23:49
aaronc
added
T: API Breaking
Breaking changes that impact APIs and the SDK only (not state machine).
R4R
labels
Jun 2, 2020
alexanderbez
reviewed
Jun 3, 2020
alexanderbez
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fedekunze
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
T: API Breaking
Breaking changes that impact APIs and the SDK only (not state machine).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to register the multisig type that @marbar3778 added in #6241 with amino (which is necessary for completing #6216), we need to move the global amino
Cdc
instance outside of thecodec
package to avoid cyclic dependencies.This PR fixes this by:
codec.RegisterCrypto
tocrypto/codec
and having it reference the amino registration incrypto/types/multisig
which was added in multisig: add type and bitarray #6241codec.Cdc
to a newcodec/legacy_global
package (which has an intentionally ugly name) and deprecating itFor contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer