Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Get* Prefixes from Key Construction Functions #6212

Merged
merged 4 commits into from
May 13, 2020
Merged

Remove Get* Prefixes from Key Construction Functions #6212

merged 4 commits into from
May 13, 2020

Conversation

kochetkov-av
Copy link
Contributor

Description

Remove Get* prefix from key construction functions:
GetValidatorSigningInfoKey => ValidatorSigningInfoKey

Add *Prefix to constant prefixes:
ValidatorSigningInfoKey => ValidatorSigningInfoKeyPrefix

closes: #2747

@auto-comment
Copy link

auto-comment bot commented May 13, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

alexanderbez
alexanderbez approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

alessio
alessio suggested changes May 13, 2020
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Though I think these public API changes should be mentioned in the CHANGELOG.

@codecov
Copy link

codecov bot commented May 13, 2020 •
edited
Loading

Codecov Report

Merging #6212 into master will not change coverage.
The diff coverage is 48.00%.

@@           Coverage Diff           @@
##           master    #6212   +/-   ##
=======================================
  Coverage   54.86%   54.86%           
=======================================
  Files         444      444           
  Lines       26788    26788           
=======================================
  Hits        14698    14698           
  Misses      11048    11048           
  Partials     1042     1042

@kochetkov-av
Copy link
Contributor Author

Looks good! Though I think these public API changes should be mentioned in the CHANGELOG.

Done

@alexanderbez alexanderbez added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label May 13, 2020
@alexanderbez alexanderbez merged commit 6214729 into cosmos:master May 13, 2020
@kochetkov-av kochetkov-av deleted the 2747-remove-get-prefix branch May 17, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio alessio approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@clevinson clevinson Awaiting requested review from clevinson

@fedekunze fedekunze Awaiting requested review from fedekunze

@hschoenburg hschoenburg Awaiting requested review from hschoenburg

@jgimeno jgimeno Awaiting requested review from jgimeno

@nylira nylira Awaiting requested review from nylira

Assignees
No one assigned
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Get* Prefixes from Key Construction Functions
3 participants
@kochetkov-av @alessio @alexanderbez