Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate x/capability to Protobuf #5926

Merged
merged 9 commits into from
Apr 6, 2020
Merged

Migrate x/capability to Protobuf #5926

merged 9 commits into from
Apr 6, 2020

Conversation

fedekunze
Copy link
Collaborator

ref: #5444

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added R4R and removed WIP labels Apr 3, 2020
@fedekunze fedekunze marked this pull request as ready for review April 3, 2020 15:33
@alexanderbez alexanderbez mentioned this pull request Apr 3, 2020
28 tasks
codec/std/codec.pb.go Outdated Show resolved Hide resolved
codec/std/codec.proto Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #5926 into ibc-alpha will increase coverage by 0.00%.
The diff coverage is 80.64%.

@@            Coverage Diff             @@
##           ibc-alpha    #5926   +/-   ##
==========================================
  Coverage      59.17%   59.18%           
==========================================
  Files            397      397           
  Lines          22982    22981    -1     
==========================================
+ Hits           13600    13601    +1     
+ Misses          8456     8454    -2     
  Partials         926      926           

x/capability/keeper/keeper.go Outdated Show resolved Hide resolved
x/capability/types/codec.go Outdated Show resolved Hide resolved
fedekunze and others added 2 commits April 3, 2020 12:56
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit 52206f4 into ibc-alpha Apr 6, 2020
@fedekunze fedekunze deleted the proto-capability branch April 6, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants