Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/keys: remove DecodeSignature from baseKeybase #5844

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 20, 2020

Keybase implementations should return errors when
signature generation is attempted with offline/multisig
keys since theyr lack private keys.

This is a change in Keyring/Keybase.Sign() methods
semantics that have been broken for long time.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #5844 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5844      +/-   ##
==========================================
- Coverage   32.33%   32.32%   -0.01%     
==========================================
  Files         353      353              
  Lines       39479    39465      -14     
==========================================
- Hits        12766    12759       -7     
+ Misses      25439    25434       -5     
+ Partials     1274     1272       -2
Impacted Files Coverage Δ
crypto/keys/keybase_base.go 75.21% <ø> (+2.69%) ⬆️
crypto/keys/keybase.go 65.95% <100%> (ø) ⬆️
crypto/keys/keyring.go 51.91% <100%> (ø) ⬆️

@alessio alessio changed the title Remove DecodeSignature from baseKeybase crypto/keys: remove DecodeSignature from baseKeybase Mar 20, 2020
@alessio alessio added the R4R label Mar 20, 2020
@alessio alessio marked this pull request as ready for review March 20, 2020 14:23
@alessio alessio requested review from jgimeno and tac0turtle March 20, 2020 14:23
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Keybase implementations should return errors when
signature generation is attempted with offline/multisig
keys since theyr lack private keys.

This is a change in Keyring/Keybase.Sign() methods
semantics that have been broken for long time.
@alessio alessio force-pushed the alessio/remove-decodesignature branch from af32902 to ae3a14c Compare March 20, 2020 14:45
@alessio alessio merged commit 75a375b into master Mar 20, 2020
@alessio alessio deleted the alessio/remove-decodesignature branch March 20, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants