Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DiffKVStores(), store/types gets 100% coverage #5730

Merged
merged 4 commits into from
Mar 2, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 29, 2020

DiffKVStores() used to return duplicated entries
in some cases.

Add test cases, aiming to reach 100% coverage for
store package.

Remove duplicate Cp function from the store package.
Same functionality is provided by types.CopyBytes().


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

DiffKVStores() used to return duplicated entries
in some cases.

Add test cases, aiming to reach 100% coverage for
store package.

Remove duplicate Cp function from the store package.
Same functionality is provided by types.CopyBytes().
@alessio alessio force-pushed the alessio/store-package-testcases branch from d097e0e to 208ec50 Compare February 29, 2020 23:42
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to do these on tendermint as well, we'd love it hehe 😄

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 2, 2020
@mergify mergify bot merged commit e0d0293 into master Mar 2, 2020
@mergify mergify bot deleted the alessio/store-package-testcases branch March 2, 2020 00:27
@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #5730 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5730      +/-   ##
==========================================
+ Coverage   36.19%   36.22%   +0.03%     
==========================================
  Files         335      335              
  Lines       32722    32722              
==========================================
+ Hits        11843    11855      +12     
+ Misses      19653    19641      -12     
  Partials     1226     1226
Impacted Files Coverage Δ
client/keys/types.go 100% <0%> (+100%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants