Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fund Community Pool -- Part II #5384

Merged
merged 4 commits into from
Dec 11, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Dec 10, 2019

A continuation of #5249 that performs some cleanup, addressing some unresolved comments and supporting simulation for the new message type.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added WIP C:x/distribution distribution module related labels Dec 10, 2019
@alexanderbez alexanderbez marked this pull request as ready for review December 10, 2019 20:01
@alexanderbez alexanderbez added R4R and removed WIP labels Dec 10, 2019
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #5384 into master will decrease coverage by 0.02%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5384      +/-   ##
==========================================
- Coverage   54.51%   54.48%   -0.03%     
==========================================
  Files         311      311              
  Lines       18719    18721       +2     
==========================================
- Hits        10205    10201       -4     
- Misses       7736     7742       +6     
  Partials      778      778
Impacted Files Coverage Δ
x/distribution/handler.go 7.14% <0%> (ø) ⬆️
x/distribution/client/cli/tx.go 4.7% <0%> (-0.06%) ⬇️
x/distribution/keeper/keeper.go 82.71% <100%> (ø) ⬆️
x/distribution/types/msg.go 56.92% <42.85%> (ø) ⬆️
x/mock/app.go 62.83% <0%> (-2.71%) ⬇️

@alexanderbez alexanderbez merged commit bcca045 into master Dec 11, 2019
@alexanderbez alexanderbez deleted the bez/5206-community-pool-funding-pt-ii branch December 11, 2019 04:02
xiangjianmeng pushed a commit to xiangjianmeng/cosmos-sdk that referenced this pull request Dec 18, 2019
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants