Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for broken links #4981

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Quick fix for broken links #4981

merged 1 commit into from
Sep 3, 2019

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Sep 2, 2019

  • this was found by nass, thankyou

  • my eidtor does a quick fix for markdown, that is why you see some more changes

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

- this was found by nass, thankyou

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #4981 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4981      +/-   ##
==========================================
+ Coverage   55.55%   55.56%   +0.01%     
==========================================
  Files         284      284              
  Lines       17460    17460              
==========================================
+ Hits         9700     9702       +2     
+ Misses       7065     7063       -2     
  Partials      695      695

@alexanderbez alexanderbez merged commit 29b8161 into master Sep 3, 2019
@alexanderbez alexanderbez deleted the marko/guicklinkfix branch September 3, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants