-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor bank tests #4909
refactor bank tests #4909
Conversation
…-refactor-bank-tests
…-refactor-bank-tests
Codecov Report
@@ Coverage Diff @@
## master #4909 +/- ##
==========================================
+ Coverage 53.67% 53.73% +0.06%
==========================================
Files 272 272
Lines 17052 17105 +53
==========================================
+ Hits 9152 9191 +39
- Misses 7210 7223 +13
- Partials 690 691 +1 |
// genesis accounts. | ||
func SetupWithGenesisAccounts(genAccs genaccounts.GenesisAccounts) *SimApp { | ||
db := dbm.NewMemDB() | ||
app := NewSimApp(log.NewTMLogger(log.NewSyncWriter(os.Stdout)), db, nil, true, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a Nop logger?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, right? Might be helpful to see logs from modules as we're running integration tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ☕️
#4875
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry to the
Unreleased
section inCHANGELOG.md
Re-reviewed
Files changed
in the github PR explorerFor Admin Use: