Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update x/genaccounts to match module spec #4759

Merged
merged 2 commits into from
Jul 22, 2019
Merged

update x/genaccounts to match module spec #4759

merged 2 commits into from
Jul 22, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jul 22, 2019 •
edited by alexanderbez
Loading

closes #4758

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added R4R Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Jul 22, 2019
@fedekunze fedekunze changed the title update x/genaccounts update x/genaccounts to match module spec Jul 22, 2019
@fedekunze fedekunze marked this pull request as ready for review July 22, 2019 09:50
@codecov
Copy link

codecov bot commented Jul 22, 2019 •
edited
Loading

Codecov Report

Merging #4759 into master will increase coverage by 0.14%.
The diff coverage is 96%.

@@            Coverage Diff             @@
##           master    #4759      +/-   ##
==========================================
+ Coverage   53.73%   53.87%   +0.14%     
==========================================
  Files         273      270       -3     
  Lines       17279    17230      -49     
==========================================
- Hits         9285     9283       -2     
+ Misses       7310     7263      -47     
  Partials      684      684

alexanderbez
alexanderbez approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

x/genaccounts/internal/types/codec.go Show resolved Hide resolved
@alessio alessio merged commit e85a734 into master Jul 22, 2019
@alessio alessio deleted the fedekunze/4758-genaccounts branch July 22, 2019 15:26
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@fedekunze
update x/genaccounts to match module spec (cosmos#4759)
7441579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update genaccounts to match module spec
3 participants
@fedekunze @alessio @alexanderbez