Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Search Txs by Events APIs #4637

Merged
merged 5 commits into from
Jun 28, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jun 28, 2019

closes: #4633


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. ready-for-review T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Jun 28, 2019
@alexanderbez alexanderbez marked this pull request as ready for review June 28, 2019 13:05
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the swagger file comments 🙏 ? I believe GET /txs has a reference to tags too.

@alexanderbez
Copy link
Contributor Author

@fedekunze updated. Thanks.

@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #4637 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #4637   +/-   ##
=======================================
  Coverage   54.11%   54.11%           
=======================================
  Files         260      260           
  Lines       16371    16371           
=======================================
  Hits         8859     8859           
  Misses       6866     6866           
  Partials      646      646

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ACK. Let's remove the required field and then update the docs again

client/lcd/swagger-ui/swagger.yaml Outdated Show resolved Hide resolved
client/lcd/swagger-ui/swagger.yaml Outdated Show resolved Hide resolved
alexanderbez and others added 3 commits June 28, 2019 09:17
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
@alexanderbez alexanderbez merged commit 3a39e9d into master Jun 28, 2019
@alexanderbez alexanderbez deleted the bez/4633-fix-query-tx-events-api branch June 28, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove QueryTxsByTags or update to search with events.
2 participants