Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: added slack notification to runsim #4547

Merged
merged 21 commits into from
Jun 26, 2019
Merged

R4R: added slack notification to runsim #4547

merged 21 commits into from
Jun 26, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jun 13, 2019

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

contrib/runsim/main.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #4547 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4547      +/-   ##
==========================================
+ Coverage   53.62%   53.63%   +0.01%     
==========================================
  Files         260      260              
  Lines       16177    16177              
==========================================
+ Hits         8675     8677       +2     
+ Misses       6856     6854       -2     
  Partials      646      646

@mircea-c mircea-c marked this pull request as ready for review June 25, 2019 20:29
contrib/runsim/notification.go Outdated Show resolved Hide resolved
contrib/runsim/main.go Outdated Show resolved Hide resolved
contrib/runsim/main.go Outdated Show resolved Hide resolved
contrib/runsim/notification.go Outdated Show resolved Hide resolved
contrib/runsim/notification.go Outdated Show resolved Hide resolved
contrib/runsim/notification.go Outdated Show resolved Hide resolved
contrib/runsim/notification.go Outdated Show resolved Hide resolved
contrib/runsim/notification.go Outdated Show resolved Hide resolved
@mircea-c mircea-c force-pushed the mircea/runsim-update branch from b907f48 to bd47b52 Compare June 25, 2019 21:51
@mircea-c mircea-c changed the title added slack notification to runsim R4R: added slack notification to runsim Jun 25, 2019
@alessio alessio merged commit 908c5cf into master Jun 26, 2019
@alessio alessio deleted the mircea/runsim-update branch June 26, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants