Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vet with golangci lint govet #4277

Merged
merged 5 commits into from
May 6, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 6, 2019

Fix inconsistencies and small mistakes as per golangci-lint run's report.

Upgrade golangci-lint to 1.16.0.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #4277 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #4277      +/-   ##
=========================================
- Coverage   59.12%   59.1%   -0.02%     
=========================================
  Files         217     217              
  Lines       14595   14595              
=========================================
- Hits         8629    8627       -2     
- Misses       5328    5330       +2     
  Partials      638     638

1 similar comment
@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #4277 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #4277      +/-   ##
=========================================
- Coverage   59.12%   59.1%   -0.02%     
=========================================
  Files         217     217              
  Lines       14595   14595              
=========================================
- Hits         8629    8627       -2     
- Misses       5328    5330       +2     
  Partials      638     638

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice cleanup

@alessio alessio merged commit 06f7b21 into master May 6, 2019
@alessio alessio deleted the alessio/replace-vet-with-golangci-lint-govet branch May 6, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants