Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No packages must depend on cmd/gaia/ #4048

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Apr 4, 2019

Preparation work for moving gaia out of the SDK.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Preparation work for moving gaia out of the SDK.
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #4048 into develop will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff            @@
##           develop    #4048   +/-   ##
========================================
  Coverage    59.81%   59.81%           
========================================
  Files          212      212           
  Lines        15158    15158           
========================================
  Hits          9066     9066           
  Misses        5448     5448           
  Partials       644      644

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessio alessio merged commit 85021d4 into develop Apr 4, 2019
@alessio alessio deleted the alessio/prep-gaia-split branch April 4, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants