-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Genesis port script v0.34.0 #4023
Conversation
Codecov Report
@@ Coverage Diff @@
## release/v0.34.0 #4023 +/- ##
===================================================
+ Coverage 59.99% 60.01% +0.01%
===================================================
Files 212 212
Lines 15107 15107
===================================================
+ Hits 9064 9066 +2
+ Misses 5422 5420 -2
Partials 621 621 |
I will test this on my full node shortly. Also, here is a WIP gist I have of the full upgrade instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @fedekunze! Left some comments. Will test on my full node shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to @rigelrozanski this needs to set a high constant fee for the new crisis module's invariant check transaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this needs the invariant fee param (from what @cwgoes suggested).
What's the value for it ? |
$5000 USD was suggested by jae online |
updated, please test again |
I think it'd be great to add the procedure in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fedekunze could we just rename this to scripts/export/v0_33_0.py
?
- script moved from scripts/ to contrib/export - Main and aux functions refactored and generalised for increased reusability in future scripts. - .gitignore updated
@gamarin2 I have a personal gist that I can port to here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo I think - need to be careful since if we don't overwrite the old field it will remain (and the new field with the wrong name will be ignored).
Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK - we should test this again with the exact exported genesis from mainnet once we have it.
Tested an export on my mainnet full node w/o any hiccups. |
Closes #4018
Run using
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: