Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Removing pkg/errors when not necessary #3557

Merged
merged 1 commit into from
Feb 8, 2019
Merged

R4R: Removing pkg/errors when not necessary #3557

merged 1 commit into from
Feb 8, 2019

Conversation

jleni
Copy link
Member

@jleni jleni commented Feb 8, 2019 •
edited
Loading

Removing pkg/errors when standard packages could be used
(as discussed in #3517 (comment).)

I dont think this deserves an entry in Pending.md, but I am happy to add it if necessary.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jleni jleni mentioned this pull request Feb 8, 2019
Merged
4 tasks
@jleni jleni changed the title Removing pkg/errors when not necessary R4R: Removing pkg/errors when not necessary Feb 8, 2019
@jleni jleni added ready-for-review Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Feb 8, 2019
@jleni
Copy link
Member Author

jleni commented Feb 8, 2019

mmm... it seems that circleci is not working well today (service partially degraded). The build passes but GitHub is not receiving the report back.

@jleni
Copy link
Member Author

jleni commented Feb 8, 2019

ok, restarting works. Ready to go

jackzampolin
jackzampolin approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackzampolin jackzampolin merged commit ba63eb1 into cosmos:develop Feb 8, 2019
@jleni jleni deleted the refac/errorsPkg branch February 21, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio alessio approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jleni @alessio @alexanderbez @jackzampolin