Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Add vendor-deps to .gitignore #3381

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jan 24, 2019

cc @alessio

Doesn't need PENDING.md.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #3381 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3381   +/-   ##
========================================
  Coverage    58.88%   58.88%           
========================================
  Files          131      131           
  Lines         9808     9808           
========================================
  Hits          5775     5775           
  Misses        3658     3658           
  Partials       375      375

@cwgoes cwgoes merged commit ccfcee8 into develop Jan 24, 2019
@cwgoes cwgoes deleted the cwgoes/add-vendor-deps-gitignore branch January 24, 2019 19:44
@alessio alessio self-requested a review January 24, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: UX tooling dev tooling within the sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants