Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Support min fees in a localnet and fix gaiad config #3172

Merged
merged 3 commits into from
Dec 20, 2018

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Dec 19, 2018

  • Support minimum fees on a local testnet (default 1stake)
  • Fix parsing/loading gaiad config (it was never being parsed/respected when it already existed)

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #3172 into develop will decrease coverage by 0.01%.
The diff coverage is 4.54%.

@@             Coverage Diff             @@
##           develop    #3172      +/-   ##
===========================================
- Coverage    54.88%   54.86%   -0.02%     
===========================================
  Files          132      132              
  Lines         9446     9452       +6     
===========================================
+ Hits          5184     5186       +2     
- Misses        3943     3947       +4     
  Partials       319      319

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested locally too!

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Just a little remark: this should be listed as breaking change due to a exported function in baseapp (SetMinimumFees) being unexported.

@alexanderbez alexanderbez added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Dec 20, 2018
@jackzampolin jackzampolin merged commit 8211c02 into develop Dec 20, 2018
@jackzampolin jackzampolin deleted the bez/min-fee-localnet branch December 20, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants