Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: change wrong password message #2994

Merged
merged 2 commits into from
Dec 4, 2018
Merged

R4R: change wrong password message #2994

merged 2 commits into from
Dec 4, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Dec 4, 2018 •
edited
Loading

Closes: #2993

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio added the wip label Dec 4, 2018
@codecov
Copy link

codecov bot commented Dec 4, 2018 •
edited
Loading

Codecov Report

Merging #2994 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2994   +/-   ##
========================================
  Coverage    55.53%   55.53%           
========================================
  Files          120      120           
  Lines         8494     8494           
========================================
  Hits          4717     4717           
  Misses        3455     3455           
  Partials       322      322

@alessio alessio changed the title WIP: change wrong password message R4R: change wrong password message Dec 4, 2018
cwgoes
cwgoes approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@cwgoes cwgoes merged commit 079b1f0 into develop Dec 4, 2018
@cwgoes cwgoes deleted the alessio/2993-wrong-password-message branch December 4, 2018 16:23
mircea-c pushed a commit that referenced this pull request Dec 5, 2018
@alessio
Merge PR #2994: Change wrong password message
90e1bde 
* change wrong password message

Closes: #2993

* Update PENDING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@fedekunze fedekunze Awaiting requested review from fedekunze

@faboweb faboweb Awaiting requested review from faboweb

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio @cwgoes