Copy ADR template from Tendermint #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
approved these changes
Sep 13, 2018
There was a problem hiding this comment.
Thanks @ValarDragon -- I also had this started when I worked on the signed message ICS, so I left a comment on the template 👍
docs/architecture/adr-template.md
Outdated
| @@ -0,0 +1,15 @@ | |||
| # ADR 000: Template for an ADR | |||
There was a problem hiding this comment.
Do you think the template I had here would be more helpful/descriptive?
There was a problem hiding this comment.
Oh cool didn't see that! Yeah that template looks way better, I'll copy it here
Codecov Report
@@ Coverage Diff @@
## develop #2333 +/- ##
========================================
Coverage 65.04% 65.04%
========================================
Files 135 135
Lines 8399 8399
========================================
Hits 5463 5463
Misses 2574 2574
Partials 362 362 |
|
I modified @alexanderbez ADR Template. I modified the descriptors a fair amount though , from my understanding with the Tendermint ADR's. Feel free to comment if anyone would like any of the section descriptors to be changed / the current state is sub-ideal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe we've been discussing adding these templates for awhile. I think its more amenable for longer proposals than github issues (as it allows threads of conversation), and was also desired in #1192
For Admin Use: