Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix Invalid Cliff Validator Power Comparison #2077

Merged
merged 3 commits into from
Aug 17, 2018

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 17, 2018

  • Fix invalid power comparison
  • Add to unit tests to check this invariant
  • Add defensive panic

closes: #2070


  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez requested a review from cwgoes August 17, 2018 14:40
@alexanderbez alexanderbez changed the title Fix Invalid Cliff Validator Power Comparison R4R: Fix Invalid Cliff Validator Power Comparison Aug 17, 2018
@cwgoes
Copy link
Contributor

cwgoes commented Aug 17, 2018

This should update the changelog since we're merging into the release branch.

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #2077 into release/v0.24.0 will increase coverage by 0.2%.
The diff coverage is 66.66%.

@@                Coverage Diff                 @@
##           release/v0.24.0    #2077     +/-   ##
==================================================
+ Coverage            63.75%   63.95%   +0.2%     
==================================================
  Files                  113      113             
  Lines                 6665     6667      +2     
==================================================
+ Hits                  4249     4264     +15     
+ Misses                2132     2119     -13     
  Partials               284      284

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK, thanks!

@cwgoes cwgoes merged commit cf03076 into release/v0.24.0 Aug 17, 2018
@cwgoes cwgoes deleted the bez/2070-fix-cliff-comp-bug branch August 17, 2018 15:33
@@ -103,6 +103,7 @@ BUG FIXES
- [x/stake] \#2021 Fixed repeated CLI commands in staking

* Gaia
- [x/stake] [#2077](https://github.com/cosmos/cosmos-sdk/pull/2077) Fixed invalid cliff power comparison
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need to put the links in the pending file I don't think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok -- I'll stop doing that.

@rigelrozanski
Copy link
Contributor

dope! Thanks Bez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants