-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(simapp): set chain-id on NewSimApp
for sim bench tests
#17138
fix(simapp): set chain-id on NewSimApp
for sim bench tests
#17138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think we need to backport this to v0.50.x, will check and add the label if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! Thank you!
Also backporting to v0.47.x as that's when the SetChainID was introduced (#15303) |
@facundomedica in the v0.47 backport we should fix the command as well. |
(cherry picked from commit 56ba5e2)
(cherry picked from commit 56ba5e2)
Description
The simulations that use either
BenchmarkFullAppSimulation
orBenchmarkInvariants
are failing with error:panic: invalid chain-id on InitChain; expected: , got: simulation-app
For example, running
make test-sim-benchmark
is a way to reproduce this issue.The error is gone once the chain-id is properly set also in those two functions.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change