Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly use --trace flag #16827

Merged
merged 4 commits into from
Jul 4, 2023
Merged

fix: properly use --trace flag #16827

merged 4 commits into from
Jul 4, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 4, 2023 •
edited
Loading

Description

blocked on #16825
using a pseudo version for now to at least fix the issue with the trace flag.
the pseudo dep will be bump after #16829.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jul 4, 2023
@julienrbrt julienrbrt changed the title fix: properly use --trace flag fix: properly use --trace flag Jul 4, 2023
@julienrbrt julienrbrt marked this pull request as ready for review July 4, 2023 17:08
@julienrbrt julienrbrt requested a review from a team as a code owner July 4, 2023 17:08
alexanderbez
alexanderbez approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julienrbrt julienrbrt added this pull request to the merge queue Jul 4, 2023
Merged via the queue into main with commit 8d80df8 Jul 4, 2023
@julienrbrt julienrbrt deleted the julien/fix-trace branch July 4, 2023 19:14
mergify bot pushed a commit that referenced this pull request Jul 4, 2023
@julienrbrt @mergify
fix: properly use --trace flag (#16827)
cfedf7d 
(cherry picked from commit 8d80df8)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 4, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jul 4, 2023
@julienrbrt @mergify
fix: properly use --trace flag (#16827)
83b6229 
(cherry picked from commit 8d80df8)

# Conflicts:
#	CHANGELOG.md
#	go.mod
#	go.sum
#	server/util.go
#	simapp/go.mod
#	simapp/go.sum
#	tests/go.mod
#	tests/go.sum
@mergify mergify bot mentioned this pull request Jul 4, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 4, 2023
@mergify @julienrbrt
fix: properly use --trace flag (backport #16827) (#16831)
1ee99c0 
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt added a commit that referenced this pull request Jul 4, 2023
@mergify @julienrbrt
fix: properly use --trace flag (backport #16827) (#16830)
2bf3414 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@jacksoom jacksoom mentioned this pull request Jul 29, 2023
Merged
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @alexanderbez