refactor(distribution)!: use collections for ValidatorHistoricalRewards state #16607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 19, 2023 11:36
github-actions
bot
added
C:collections
C:x/distribution
github-prbot
requested review from
a team,
kocubinski and
julienrbrt
and removed request for
a team
julienrbrt
reviewed
Jun 19, 2023
added 2 commits
June 20, 2023 15:50
# Conflicts: # simapp/go.sum # tests/go.sum
added 2 commits
June 20, 2023 17:19
added 3 commits
June 22, 2023 10:31
# Conflicts: # x/evidence/go.sum
julienrbrt
reviewed
Jun 22, 2023
There was a problem hiding this comment.
This looked weird, so I go mod tidy in this PR: #16616.
There was a problem hiding this comment.
Goland EAP does weird things with go.sum I always revert them, this time I forgot. Sorry 🙏
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16608
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change