refactor(crisis)!: use collections for state management #16328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
kocubinski and
JeancarloBarrios
and removed request for
a team
testinginprod
commented
May 29, 2023
| } | ||
|
|
||
| // GetConstantFee set's the constant fee in the store | ||
| func (k *Keeper) SetConstantFee(ctx context.Context, constantFee sdk.Coin) error { |
There was a problem hiding this comment.
This function was only used in genesis and update params, in both we check for constant fee validity which means this function was doing a redundant check.
testinginprod
commented
May 29, 2023
| ) | ||
|
|
||
| // GetConstantFee get's the constant fee from the store | ||
| func (k *Keeper) GetConstantFee(ctx context.Context) (constantFee sdk.Coin, err error) { |
There was a problem hiding this comment.
This is only used in Genesis export and getting the constant fee for invariance checks. Here the behavioural change is that before it wouldn't error if it did not exist, which is a bug since it's impossible to send invalid coins.
tac0turtle
approved these changes
May 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16327
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change