-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow setting the base denom #16257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code-wise lgtm, but I am curious about the use-case of this.
When do you need to change the base denom?
Imagine if you want to register multiple coin denoms to operate with different precision on different applications (while coding for a core module or on cosmwasm smart contract) but you don't want to change the default denom on the unit with more precision (as coded here). E.g.: when upgrading the core for backwards compatibility, register multiple denoms with precision 10^-3, 10^-6, 10^-9 but use the same old denom with 10^-6 precision. |
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Description
Allow changing the default base denom from types with any other previously registered denom.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change