-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: call AfterUnbondingInitiated for new unbonding entries only #16043
Conversation
Can we get a changelog + a test here? |
Yes. I'll add the tests and the changelog 👍 |
Currently working on: Just curious if this will be able to be backported to 47, or if we need to begin to target main. Thanks. |
f06b4bf
to
9867dd7
Compare
@julienrbrt Tests and changelog entries were added. |
Thanks, could you fix the linting issues? |
Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! However, I do not think we can backport that to v0.47 🤔
Reminder for myself, precise a behavior change in the UPGRADING.md and/or changelog. |
Description
Closes: #16042
An earlier change in #12967 introduced behaviour that causes the
AfterUnbondingInitiated
staking hook to be called with an invalidunbondingId
inSetUnbondingDelegationEntry
. The issue affects unbonding operations, redelegation behaviour does not seem to be affected. The issue can cause interchain-security provider chains to panic.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change