Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: UX Mempool Tweaks (backport #15121) #15122

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 22, 2023

This is an automatic backport of pull request #15121 done by Mergify.
Cherry-pick of 77660ec has failed:

On branch mergify/bp/release/v0.47.x/pr-15121
Your branch is up to date with 'origin/release/v0.47.x'.

You are currently cherry-picking commit 77660ec45.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   types/mempool/sender_nonce.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   types/mempool/priority_nonce.go
	both modified:   types/mempool/priority_nonce_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 77660ec)

# Conflicts:
#	types/mempool/priority_nonce.go
#	types/mempool/priority_nonce_test.go
@mergify mergify bot requested a review from a team as a code owner February 22, 2023 02:22
@mergify mergify bot added the conflicts label Feb 22, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should remove usage of global bech32 usage

@alexanderbez
Copy link
Contributor

should remove usage of global bech32 usage

This doesn't make sense IMO. Bech32 isn't going anywhere.

@alexanderbez alexanderbez deleted the mergify/bp/release/v0.47.x/pr-15121 branch February 22, 2023 14:14
@tac0turtle
Copy link
Member

should remove usage of global bech32 usage

This doesn't make sense IMO. Bech32 isn't going anywhere.

it wont be a global anymore is what im trying to say. it will be local to auth allowing app devs to define their own address encoding if they want. This would require a custom auth module

@mergify mergify bot mentioned this pull request Feb 22, 2023
19 tasks
@alexanderbez alexanderbez restored the mergify/bp/release/v0.47.x/pr-15121 branch February 22, 2023 16:00
@alexanderbez alexanderbez reopened this Feb 22, 2023
@alexanderbez
Copy link
Contributor

Yeah, however we define it, it'll be wired through to the mempool via an interface or something that doesn't depend on x/auth. There are many places in the SDK that require or find Bech32 useful, so it's not just limited to mempool.

@tac0turtle tac0turtle dismissed their stale review February 22, 2023 16:39

dismissing for 0.47

@alexanderbez alexanderbez enabled auto-merge (squash) February 22, 2023 16:50
@alexanderbez alexanderbez merged commit 2dc33a5 into release/v0.47.x Feb 22, 2023
@alexanderbez alexanderbez deleted the mergify/bp/release/v0.47.x/pr-15121 branch February 22, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants