-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: UX Mempool Tweaks (backport #15121) #15122
chore: UX Mempool Tweaks (backport #15121) #15122
Conversation
(cherry picked from commit 77660ec) # Conflicts: # types/mempool/priority_nonce.go # types/mempool/priority_nonce_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remove usage of global bech32 usage
This doesn't make sense IMO. Bech32 isn't going anywhere. |
it wont be a global anymore is what im trying to say. it will be local to auth allowing app devs to define their own address encoding if they want. This would require a custom auth module |
Yeah, however we define it, it'll be wired through to the mempool via an interface or something that doesn't depend on |
This is an automatic backport of pull request #15121 done by Mergify.
Cherry-pick of 77660ec has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com